Adding support for packer 1.5.0 and hcl2 #11
Merged
+254
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated Provisioner signature to include the `_ map[string]interface{}` see [GH-7866](hashicorp/packer#7866) for details.
* Updated README.md to include development section on required auto generation of hclspec.go for provisioner.
* Generated the provisioner.hc2spec.go as documented in the README.md
* See [component-object-spec guide](https://github.com/hashicorp/packer/blob/master/website/source/guides/hcl/component-object-spec/index.html.md.erb) for details on how the autogeneration was performed.
* Added required hcldec dependency and updated go mods.
* Updated to packer 1.5.4 from 1.5.0 * Updated circleci golang image
|
Any chance this gets reviewed/Merged? |
blakeneyops
approved these changes
Apr 30, 2020
* Updating readme to show packer 1.5.4 version is used.
disaac
deleted the
dmi-packer-1.5.0-update-hcl2-provisioner-sig-change-issue-
branch
@supernovae The update has been merged and binaries are available under relase packer-provisioner-serverspec v0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10
_ map[string]interface{}see GH-7866 for details.